hover point throttle curve adjustment #4245
Conversation
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
There is no need to add translations beside |
|
Oh okay, sorry. Should I remove the other ones? |
src/js/tabs/pid_tuning.js
Outdated
| @@ -113,6 +113,7 @@ pid_tuning.initialize = function (callback) { | |||
|
|
|||
| $('.throttle input[name="mid"]').val(FC.RC_TUNING.throttle_MID.toFixed(2)); | |||
| $('.throttle input[name="expo"]').val(FC.RC_TUNING.throttle_EXPO.toFixed(2)); | |||
| $('.throttle input[name="hover"]').val(FC.throttle_HOVER.toFixed(2)); | |||
There was a problem hiding this comment.
FC.THROTTLE_HOVER should be a member of some PG to be decided in firmware.
There was a problem hiding this comment.
If you want to use FC.RC_TUNING.throttle_HOVER it should be added to firmware MSP message.
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week. |
|
@marc-frank , if it is not clear, please understand if you wish to achieve this feature, the firmware must be modified as well as previously stated by @haslinghuis . @bw1129, @ChrisRosser , any thoughts on this feature? |
|
I have a draft for the modification of the FC firmware. Not completed yet and I haven't figured out how I can test it myself. I'll keep working on it. |
I think it's a natural extension of the control we have over throttle feel right now. Throttle MID and EXPO allow fine resolution around the hover point but don't allow you to control where the hover point is in terms of stick travel. This feature accomplishes that. I don't like the way it creates a discontinuity in the throttle curve. I think modifying the underlying throttle curve as a bezier with HOVER POINT would give the same effect without a discontinuity of gradient. MID and EXPO could then work on that bezier curve to add expo. |
|
@marc-frank @nerdCopter @haslinghuis @ChrisRosser I really like this! As Chris said, a natural extension/improvement to what's there. |
|
Here is a simple example of how to make Hoverpoint smooth. |
that looks nice. another good way to do it
|
|
Just created a fw pull request |
|
another note: do not update package.json/yarn.lock in a feature PR. |
nerdCopter
force-pushed
the
hover-point
branch
from
1d2a641 to
1d7a250
Compare
|
|
fix is force-pushed. |
|
works fine here and all my changes seem to be there, too |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
i redid the cloning and branch switch with the git bash cli and now it's all fine |
Hi, I'd like to propose a new feature / change to an existing feature: setting the hover point of a quad to 50% of the throttle stick range.
I have been using subtrim in EdgeTX in center only mode to achieve this already, but it is a quad specific setting which I'd like to have in Betaflight.
Setting the hover point to 50% stick travel gives you a lot more "resolution" between 0 throttle and the hover point, therefore making flying at lower throttle in tight spaces a lot easier.
https://discord.com/channels/868013470023548938/1303071076342956072
hover_point.mp4